[FFmpeg-devel] [PATCH] doc: avoid incorrect phrase 'allows to'

Lou Logan lou at lrcd.com
Sun Jun 14 23:32:25 CEST 2015


Apologies for the formatting.

On Sun, Jun 14, 2015, at 10:49 AM, Andreas Cadhalpun wrote:
> Signed-off-by: Andreas Cadhalpun <Andreas.Cadhalpun at googlemail.com>
> ---
>  Changelog                   | 2 +-
>  doc/decoders.texi           | 2 +-
>  libavcodec/bitstream.c      | 2 +-
>  libavcodec/libspeexenc.c    | 2 +-
>  libavcodec/ppc/me_cmp.c     | 2 +-
>  libavcodec/vp9.c            | 2 +-
>  libavcodec/x86/vc1dsp_mmx.c | 2 +-
>  libavdevice/alsa_dec.c      | 2 +-
>  libavdevice/alsa_enc.c      | 2 +-
>  libavdevice/avdevice.h      | 2 +-
>  libavformat/avformat.h      | 6 +++---
>  libavutil/opt.h             | 2 +-
>  12 files changed, 14 insertions(+), 14 deletions(-)
> 
> diff --git a/Changelog b/Changelog
> index 9a53286..3853978 100644
> --- a/Changelog
> +++ b/Changelog
> @@ -574,7 +574,7 @@ easier to use. The changes are:
>            all the stream in the first input file, except for the second
>            audio
>            stream'.
>      * There is a new option -c (or -codec) for choosing the
>      decoder/encoder to
> -      use, which allows to precisely specify target stream(s)
> consistently with
> +      use, which makes it possible to precisely specify target stream(s)
> consistently with
>        other options. E.g. -c:v lib264 sets the codec for all video
>        streams, -c:a:0
>        libvorbis sets the codec for the first audio stream and -c copy
>        copies all
>        the streams without reencoding. Old -vcodec/-acodec/-scodec
>        options are now
> diff --git a/doc/decoders.texi b/doc/decoders.texi
> index 68196cf..2fb533a 100644
> --- a/doc/decoders.texi
> +++ b/doc/decoders.texi
> @@ -95,7 +95,7 @@ This decoder aims to implement the complete FLAC
> specification from Xiph.
>  
>  @item -use_buggy_lpc
>  The lavc FLAC encoder used to produce buggy streams with high lpc values
> -(like the default value). This option allows to decode such streams
> +(like the default value). This option makes it possible to decode such
> streams
>  correctly by using lavc's old buggy lpc logic for decoding.
>  
>  @end table
> diff --git a/libavcodec/bitstream.c b/libavcodec/bitstream.c
> index 0074234..924cc51 100644
> --- a/libavcodec/bitstream.c
> +++ b/libavcodec/bitstream.c
> @@ -265,7 +265,7 @@ static int build_table(VLC *vlc, int table_nb_bits,
> int nb_codes,
>     'xxx_size' : gives the number of bytes of each entry of the 'bits'
>     or 'codes' tables.
>  
> -   'wrap' and 'size' allows to use any memory configuration and types
> +   'wrap' and 'size' make it possible to use any memory configuration
> and types
>     (byte/word/long) to store the 'bits', 'codes', and 'symbols' tables.
>  
>     'use_static' should be set to 1 for tables, which should be freed
> diff --git a/libavcodec/libspeexenc.c b/libavcodec/libspeexenc.c
> index 22d0d6e..fac8e72 100644
> --- a/libavcodec/libspeexenc.c
> +++ b/libavcodec/libspeexenc.c
> @@ -76,7 +76,7 @@
>   *     encodes them with just enough bits to reproduce the background
>   noise.
>   *
>   * Discontinuous Transmission (DTX)
> - *     DTX is an addition to VAD/VBR operation, that allows to stop
> transmitting
> + *     DTX is an addition to VAD/VBR operation, that makes it possible
> to stop transmitting
>   *     completely when the background noise is stationary.
>   *     In file-based operation only 5 bits are used for such frames.
>   */
> diff --git a/libavcodec/ppc/me_cmp.c b/libavcodec/ppc/me_cmp.c
> index 38a7ba1..26755cc 100644
> --- a/libavcodec/ppc/me_cmp.c
> +++ b/libavcodec/ppc/me_cmp.c
> @@ -504,7 +504,7 @@ static int hadamard8_diff8x8_altivec(MpegEncContext
> *s, uint8_t *dst,
>  }
>  
>  /*
> - * 16x8 works with 16 elements; it allows to avoid replicating loads,
> and
> + * 16x8 works with 16 elements; it allows one to avoid replicating
> loads, and

Possible alternatives:

...elements; it avoids replicating loads, and...
...elements; it can avoid replicating loads, and...

>   * gives the compiler more room for scheduling. It's only used from
>   * inside hadamard8_diff16_altivec.
>   *
> diff --git a/libavcodec/vp9.c b/libavcodec/vp9.c
> index d5147e5..4e2ed53 100644
> --- a/libavcodec/vp9.c
> +++ b/libavcodec/vp9.c
> @@ -3286,7 +3286,7 @@ static void decode_b(AVCodecContext *ctx, int row,
> int col,
>      }
>  
>      // emulated overhangs if the stride of the target buffer can't hold.
>      This
> -    // allows to support emu-edge and so on even if we have large block
> +    // makes it possible to support emu-edge and so on even if we have
> large block
>      // overhangs
>      emu[0] = (col + w4) * 8 > f->linesize[0] ||
>               (row + h4) > s->rows;
> diff --git a/libavcodec/x86/vc1dsp_mmx.c b/libavcodec/x86/vc1dsp_mmx.c
> index f11170c..0c2584d 100644
> --- a/libavcodec/x86/vc1dsp_mmx.c
> +++ b/libavcodec/x86/vc1dsp_mmx.c
> @@ -80,7 +80,7 @@
>      "movq      %%mm"#R1", "#OFF"(%1)   \n\t"    \
>      "add       %2, %0                  \n\t"
>  
> -/** Sacrifying mm6 allows to pipeline loads from src */
> +/** Sacrifying mm6 makes it possible to pipeline loads from src */

"Sacrifying" looks like a typo for "Sacrificing", or it's a word I've
never seen before.

I'm not a fan of the "one" pronoun (I don't hear it much in 'Merican
English), but the rest LGTM.


More information about the ffmpeg-devel mailing list