[FFmpeg-devel] [PATCH v3] * mpegts demuxer recognizes private streams on demand

[Wolfgang Lorenz]

No answers?

Well, I do have a question.

Am Thu, 4 Jun 2015 23:46:21 +0200
schrieb Wolfgang Lorenz <wl-chmw at gmx.de>:

> The option went into the MpegTSContext struct and can be addressed via
> dictionary:
> 
>     AVFormatContext * formatContext = NULL;
> 
>     /* enable mpeg-ts private stream recognition */
>     AVDictionary * dict = NULL;
>     av_dict_set_int(&dict, "mpegts_recognize_private_streams", 1, 0);
> 
>     /* open file */
>     avformat_open_input(&formatContext, fileName, NULL, &dict);
> 
> [...]

While I have used some kind of name scoping for the dictionary access,
to avoid name clashes, I've seen, that this is not done for the rest of
the formats. I think in most cases, this won't matter anyway. There are
many doubling names between different input formats, but these won't
make a problem, as one format context can only contain one input
format. I've seen one name clash between AVFormatContext and an input
format ("auto", mov.c), and "strict" seems to be declared twice for
AVFormatContext. So, here's my question: Is there any kind of
convention for naming options? And should I rename my option to
"recognize_private_streams", or something different, to get the patch
accepted? Recommendations are welcome.

Okay, that's two questions. Anyway...

Greetings,
  Wolfgang
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: not available
URL: <https://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20150610/38d315e0/attachment.asc>