[FFmpeg-devel] Fwd: [PATCH 1/2] ffmpeg: reset tty state correctly

[Nicolas George]

Le nonidi 9 thermidor, an CCXXIII, Ganesh Ajjanagadde a écrit :
> Apologies for this; I accidentally replied just to the responder and
> not the mailing list.

I replied:

> Apparently zsh was not doing it.

ttyctl -f

> Core is still being dumped due to the abort call.
> The handler is pretty minimal, just restoring tty state (necessary due
> to above), writing a message, and then calling abort.

It still obscures the state that caused the signal in the first place, and
thus make debugging harder. I consider this unacceptable and will still
object the patch.

Regarding casting to void: if there is no non-intrusive and portable to
silence that warning, then that warning is badly implemented and should be
disabled.

Regards,

-- 
  Nicolas George
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20150727/55c2e188/attachment.sig>