[FFmpeg-devel] [PATCH] libavcodec/qsvdec_h264.c bug fixed: decoder fails after restart on non-annex-b content.

[Michael Niedermayer]

On Sat, Jul 25, 2015 at 09:02:55PM +0300, Ivan Uskov wrote:
> Hello Michael,
> 
> Saturday, July 25, 2015, 8:21:44 PM, you wrote:
> >> MN> would this be faster ?
> >> MN> avoid a copy/malloc ?
> >> If it implemented inside libavcodec/qsvdec_h264.c then it will use
> >> about same code like current bsf implementation uses but with using of
> >> private buffer for sps/pps instead public extradata buf using.
> >> 
> >> Here can  be the trick to write SPS/PPS directly to
> >> QSVContext::input_fifo which implemented recently into qsvdec.
> >> It will not solve memory copying necessity but it will solve possible twice memory
> >> copying issue when packet re-allocation perform into mp4toannexb filter then
> >> data copies again into input_fifo since qsv decoder did not consume
> >> previous packet in full. What do you think?
> 
> MN> does this affect a large memcpy() on a common path ?
> 
> MN> if it avoids just a rare or small case then its not worth it
> I believe this trick will no give visible improvement in performance.
> Just small win in some rare cases.

then its better to avoid duplicating the bitstream filter

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Democracy is the form of government in which you can choose your dictator
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 181 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20150725/501e0b5a/attachment.sig>