[FFmpeg-devel] [PATCH] libavcodec/qsvdec_h264.c bug fixed: decoder fails after restart on non-annex-b content.

[Michael Niedermayer]

On Sat, Jul 25, 2015 at 12:37:25PM +0300, Ivan Uskov wrote:
> Hello Michael,
> 
> Friday, July 24, 2015, 11:24:30 PM, you wrote:
> 
> 
> MN> it should be possible to add a parameter (passed through args)
> MN> which disables extradata mangling to h264_mp4toannexb_bsf
> 
> I'm sorry, I do not see this possibility.
> The h264_extradata_to_annexb() into h264_mp4toannexb_bsf replaces
> extradata unconditionally.
> 
> This function calls by h264_mp4toannexb_filter() under simple
> condition:
>     if (!ctx->extradata_parsed) {
>         ret = h264_extradata_to_annexb(ctx, avctx, FF_INPUT_BUFFER_PADDING_SIZE);
>         <...>
>         ctx->extradata_parsed = 1;
>     }
> 
> Looks like no any parameters to avoid extradata substitution by h264_mp4toannexb_bsf.

yes, h264_mp4toannexb_bsf needs to be changed to optionally support
not doing that.
One way is to use the args for that and for example check for a
specific keyword like "skip_extradata"

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

I have never wished to cater to the crowd; for what I know they do not
approve, and what they approve I do not know. -- Epicurus
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 181 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20150725/a095423b/attachment.sig>