[FFmpeg-devel] [PATCH] fate: Make ffprobe tests depend on avdevice

[James Almer]

On 22/07/15 4:32 PM, Michael Niedermayer wrote:
> On Wed, Jul 22, 2015 at 02:54:33PM -0300, James Almer wrote:
>> On 22/07/15 2:26 PM, Michael Niedermayer wrote:
>>> From: Michael Niedermayer <michael at niedermayer.cc>
>>>
>>> The test file they use needs avdevice to be created
>>>
>>
>> Is this really needed? We have a fate client compiled with --disable-avfilter
>> here: http://fate.ffmpeg.org/history.cgi?slot=x86_64-archlinux-gcc-disableavdevice
>> And it doesn't run these tests.
> 
> ./configure  --cc='ccache gcc' --samples=...fate/fate-suite/ --disable-avdevice && make -j12 fate
> ...
> GEN     tests/data/ffprobe-test.nut
> make: *** [tests/data/ffprobe-test.nut] Error 1
> make: *** Waiting for unfinished jobs....
> LD      ffprobe_g
> 
> the patch fixed that

Just checked the logs from that client and found that error. FATE didn't register
it as a failed test i suppose because no relevant tests were run to begin with.
Makes me wonder how many similar ignored failures are there in between all that
green...

Patch is ok then.