[FFmpeg-devel] [PATCH] Replace AV_PKT_DATA_QUALITY_FACTOR by AV_PKT_DATA_QUALITY_STATS

[Michael Niedermayer]

On Tue, Jul 21, 2015 at 02:10:56PM +0200, Michael Niedermayer wrote:
> On Tue, Jul 21, 2015 at 01:41:59PM +0200, Nicolas George wrote:
> > Le tridi 3 thermidor, an CCXXIII, Michael Niedermayer a écrit :
> > > -    AV_PKT_DATA_QUALITY_FACTOR,
> > > +    AV_PKT_DATA_QUALITY_STATS,
> > 
> > > +#define AV_PKT_DATA_QUALITY_FACTOR please_use_AV_PKT_DATA_QUALITY_STATS_which_is_a_superset_of_it
> > 
> > It breaks source compatibility with the fork. Is it on purpose? Is there a
> > drawback in making AV_PKT_DATA_QUALITY_FACTOR a synonym of
> > AV_PKT_DATA_QUALITY_STATS (possibly with a deprecation warning if possible)
> > instead?
> 
> i wasnt sure how to make it show a deprecation warning, do you
> have an idea ?
> 
> the drawback without any warning is that endianness mismatches on big
> endian and that could lead to bugs

applied and left it as synonym, if someone knows how to deprecate a
preprocessor symbol please do
we can also still remove the synonym if people prefer

Thanks

[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

No great genius has ever existed without some touch of madness. -- Aristotle
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 181 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20150722/d55a1fbf/attachment.sig>