[FFmpeg-devel] [PATCH v5] Add support for Audible AAX (and AAX+) files

Vesselin Bontchev vesselin.bontchev at yandex.com
Sat Jul 18 11:44:57 CEST 2015


18.07.2015, 01:45, "Michael Niedermayer" <michael at niedermayer.cc>:
> On Thu, Jul 16, 2015 at 03:57:26AM +0300, Vesselin Bontchev wrote:
>>  + // extracted from libAAX_SDK.so and AAXSDKWin.dll files!
>
>>  + uint8_t fixed_key[] = { 0x77, 0x21, 0x4d, 0x4b, 0x19, 0x6a, 0x87, 0xcd,
>>  + 0x52, 0x00, 0x45, 0xfd, 0x20, 0xa5, 0x1d, 0x67 };
>
> I think this should not be hardcoded but provided by the user via
> an AVOption.

I fear that doing this will impact the usability negatively. Are there strong reasons for suggesting this change? 

How about documenting the fixed key (and then going the AVOption way), sounds fair?

Vesselin


More information about the ffmpeg-devel mailing list