[FFmpeg-devel] [PATCH] avformat/isom: utilize bitrate hints

Michael Niedermayer michael at niedermayer.cc
Sun Jul 12 20:23:24 CEST 2015


On Sun, Jul 12, 2015 at 05:43:10PM +0200, Hendrik Leppkes wrote:
> On Sun, Jul 12, 2015 at 5:22 PM, Carl Eugen Hoyos <cehoyos at ag.or.at> wrote:
> > Ganesh Ajjanagadde <gajjanagadde <at> gmail.com> writes:
> >
> >> -    avio_rb32(pb); /* max bitrate */
> >> -    avio_rb32(pb); /* avg bitrate */
> >> +    st->codec->rc_max_rate = avio_rb32(pb); /* max bitrate */
> >> +    st->codec->bit_rate = avio_rb32(pb); /* avg bitrate */
> >
> > The documentation states (currently!) that
> > these fields must not be set outside of
> > libavcodec for decoding.
> >
> 
> At least bit_rate is set by a bunch of demuxers as well, rc_max_rate
> probably not, but there is no harm at all in setting these.

applied

thanks

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

It is what and why we do it that matters, not just one of them.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 181 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20150712/4e8225d3/attachment.sig>


More information about the ffmpeg-devel mailing list