[FFmpeg-devel] [PATCH] libavcodec/qsvenc.c: Fix for too agressive height alignment during frame encoding which may be reason of superflous frame copying.

[Ivan Uskov]

Hello Michael,

Ooops, missed that you modified the file recently. Will prepare
another patch.
By the way, now I can not compile master repo under --enable-libmfx config,
there is compiler error appears:
libavcodec/qsvenc_hevc.c:71:5: error: too few arguments to function ‘ff_hevc_extract_rbsp’
Are there some update should be soon?

Also, do you know a real reason to make
  q->width_align = avctx->codec_id == AV_CODEC_ID_HEVC ? 32 : 16;
into the qsvenc.c? I did not check it yet and never work with Intel
HEVC before but all Intel's samples never perform such check, width
alignment in latest Intel's samples is always 16...


Thursday, July 9, 2015, 3:18:58 PM, you wrote:

MN> On Thu, Jul 09, 2015 at 02:24:43PM +0300, Ivan Uskov wrote:
>> Hello All,
>> 
>> There is another place into libavcodec/qsvenc.c where height may be
>> aligned to 32 for the case when alignment to 16 is enough. It can be
>> reason of superfluous frame copying. The attached patch does solve
>> this issue. Please review.

MN> does not apply cleanly

MN> Applying: libavcodec/qsvenc.c: Fix for too agressive height
MN> alignment during frame encoding which may be reason of superflous frame copying.
MN> Using index info to reconstruct a base tree...
MN> Falling back to patching base and 3-way merge...
MN> Auto-merging libavcodec/qsvenc.h
MN> Auto-merging libavcodec/qsvenc.c
MN> CONFLICT (content): Merge conflict in libavcodec/qsvenc.c
MN> Failed to merge in the changes.
MN> Patch failed at 0001 libavcodec/qsvenc.c: Fix for too agressive
MN> height alignment during frame encoding which may be reason of superflous frame copying.

MN> [...]




-- 
Best regards,
 Ivan                            mailto:ivan.uskov at nablet.com