[FFmpeg-devel] [PATCH 2/3] hevcdsp: replace the SAOParams struct parameter from sao_band_filter

Christophe Gisquet christophe.gisquet at gmail.com
Fri Jan 30 21:41:01 CET 2015


2015-01-30 19:50 GMT+01:00 James Almer <jamrial at gmail.com>:
> Pass instead the two variables from the struct needed in the function.
> This simplifies writing asm optimized versions of the function

ok, no impact by itself but...

>      void (*sao_band_filter)(uint8_t *_dst, uint8_t *_src, ptrdiff_t _stride_dst, ptrdiff_t _stride_src,
> -                            struct SAOParams *sao, int width, int height, int c_idx);
> +                            int16_t *sao_offset_val, int sao_left_class, int width, int height);

Not knowing how it is used, would it be useful for the passed
offset_val to be aligned? (In which case reordering the table could be
useful (maybe).

But if I'm not mistaken, the first value in that table is 0, and is
probably useless (just for adding 0 to elements not modified), so
probably not the case. More on this later.


More information about the ffmpeg-devel mailing list