[FFmpeg-devel] [PATCH] remove libmpcodecs

[Stefano Sabatini]

On date Tuesday 2015-01-27 11:28:52 +0000, Paul B Mahol encoded:
> Signed-off-by: Paul B Mahol <onemda at gmail.com>
> ---
>  Changelog                                  |   1 +
>  LICENSE.md                                 |   2 -
>  configure                                  |   1 -
>  doc/filters.texi                           |  30 --
>  libavfilter/Makefile                       |   1 -
>  libavfilter/allfilters.c                   |   1 -
>  libavfilter/libmpcodecs/cpudetect.h        |  60 ---
>  libavfilter/libmpcodecs/img_format.c       | 244 ---------
>  libavfilter/libmpcodecs/img_format.h       | 309 ------------
>  libavfilter/libmpcodecs/libvo/fastmemcpy.h |  99 ----
>  libavfilter/libmpcodecs/mp_image.c         | 257 ----------
>  libavfilter/libmpcodecs/mp_image.h         | 159 ------
>  libavfilter/libmpcodecs/mp_msg.h           | 166 -------
>  libavfilter/libmpcodecs/vf.h               | 167 -------
>  libavfilter/libmpcodecs/vf_softpulldown.c  | 163 ------
>  libavfilter/libmpcodecs/vfcap.h            |  56 ---
>  libavfilter/version.h                      |   4 +-
>  libavfilter/vf_mp.c                        | 772 -----------------------------
>  18 files changed, 3 insertions(+), 2489 deletions(-)
>  delete mode 100644 libavfilter/libmpcodecs/cpudetect.h
>  delete mode 100644 libavfilter/libmpcodecs/img_format.c
>  delete mode 100644 libavfilter/libmpcodecs/img_format.h
>  delete mode 100644 libavfilter/libmpcodecs/libvo/fastmemcpy.h
>  delete mode 100644 libavfilter/libmpcodecs/mp_image.c
>  delete mode 100644 libavfilter/libmpcodecs/mp_image.h
>  delete mode 100644 libavfilter/libmpcodecs/mp_msg.h
>  delete mode 100644 libavfilter/libmpcodecs/vf.h
>  delete mode 100644 libavfilter/libmpcodecs/vf_softpulldown.c
>  delete mode 100644 libavfilter/libmpcodecs/vfcap.h
>  delete mode 100644 libavfilter/vf_mp.c

Nit: I'd prefer if you'd remove softpulldown.c as a separate commit,
so that it's easier to revert this commit for testing reasons.

[...]
> diff --git a/libavfilter/version.h b/libavfilter/version.h
> index ce22f7b..4e50688 100644
> --- a/libavfilter/version.h
> +++ b/libavfilter/version.h
> @@ -30,8 +30,8 @@
>  #include "libavutil/version.h"
>  
>  #define LIBAVFILTER_VERSION_MAJOR  5
> -#define LIBAVFILTER_VERSION_MINOR  9
> -#define LIBAVFILTER_VERSION_MICRO 101
> +#define LIBAVFILTER_VERSION_MINOR  10
> +#define LIBAVFILTER_VERSION_MICRO 100

A micro bump is enough, since there is no new added feature.

[...]

LGTM otherwise.
-- 
FFmpeg = Fascinating and Fast Muttering Picky Elaborated Guide