[FFmpeg-devel] libavutil: Added twofish block cipher

[supraja reddy]

Hello,

> +    for (i = 0; i < cs->ksize; i++) {
> > +        Me[i] = Key[2 * i];
> > +        Mo[i] = Key[2 * i + 1];
> > +    }
> > +    for (i = 0; i < cs->ksize; i++)
> > +        cs->S[cs->ksize - i - 1] = tf_RS(Me[i], Mo[i]);
>
> Can't the previous two for loops be merged together?
>
>
You wanted me to divide the two sets earlier so I had split them up. I have
merged them now anyways.


> > +/**
> > +  * Initialize an AVTWOFISH context.
> > +  *
> > +  * @param ctx an AVTWOFISH context
> > +  * @param key a key of size ranging from 1 to 32 bytes used for
> encryption/decryption
> > +  * @param key_bits number of keybits: 128, 192, 256 If less than the
> required, padded with zeroes to nearest valid value
> > + */
>
> You need to document the return values of this function.
>

I hope the documentation is proper and as requested.

I have updated the patch. Please let me know of any further changes.

Thanks,
Supraja

​
-------------- next part --------------
A non-text attachment was scrubbed...
Name: tf6.patch
Type: text/x-patch
Size: 22200 bytes
Desc: not available
URL: <https://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20150128/6a82e533/attachment.bin>