[FFmpeg-devel] Suggested Patch for timecode timebase calculation in mov.c

[Michael Niedermayer]

On Fri, Jan 23, 2015 at 04:26:59AM +0100, Michael Niedermayer wrote:
> On Thu, Jan 22, 2015 at 09:09:53AM -0800, jon wrote:
> > I never heard back about this and I think I have a new better
> 
> are you subscribed to ffmpeg-devel ?
> 
> 
> > solution now. I don't think the current mov.c timecode processing is
> > handling the case where the timecode is in counter mode. Please read
> > the following page 190 from:
> > 
> > https://developer.apple.com/library/mac/documentation/QuickTime/QTFF/qtff.pdf
> > 
> > Specifically:
> > 
> > "Number of frames
> > An 8-bit integer that contains the number of frames per second for
> > the timecode format. If the time is a counter, this is the number of
> > frames for each counter tick."
> > 
> > I have sample media in counter mode if it helps. I tried to send
> > that before as well, but I think it was too large. Please let me
> > know how else I can help with this enhancement. Feel free to send
> > clarification questions to me.
> 
> yes, please provide a sample
> you can upload it via ftp see http://ffmpeg.org/bugreports.html
> any url that allows downloading from with wget works too

thanks for the sample
seems to fix/improve it

patch applied

ive also spotted a text in mov_read_timecode_track() about the counter
flag, this probably should be updated somehow

[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

While the State exists there can be no freedom; when there is freedom there
will be no State. -- Vladimir Lenin
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 181 bytes
Desc: Digital signature
URL: <https://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20150123/001ee537/attachment.asc>