[FFmpeg-devel] [PATCH] Port mp=eq/eq2 to FFmpeg

[Christophe Gisquet]

So...

2015-01-21 21:08 GMT+01:00 arwa arif <arwaarif1994 at gmail.com>:
> Updated the patch.

There are trailing spaces, and the patch does not apply here (error on
libavfilter/x86/Makefile)

Furthemore, I think that hunk is incorrect:

+    set_gamma(eq);
+    set_contrast(eq);
+    set_brightness(eq);
+    set_saturation(eq);
+
+    for (i = 0; i < 3; i++) {
+        eq->param[i].c = (eq->param[i].contrast) * 65536.0;
+        eq->param[i].b = (eq->param[i].brightness + 1.0) * 255.5 -
128.0 - (eq->param[i].contrast) * 128.0;
+    }
+
+    eq->process = process_c;
+
+    if (ARCH_X86)
+        ff_eq_init_x86(eq);

The adjust function pointer may be set to eq->process potentially, but
eq->process won't ever be set at that moment, as it is set in the last
part.

Once fixed, I get with gcc 4.9.2, Mingw64 (not msys2) on a core i5-460
(up to sse4.2)
C:   16098398 decicycles in eq, 2048 runs, 0 skips CRC=0xb4a713e1
MMX:  5912547 decicycles in eq, 2048 runs, 0 skips CRC=0x1dfc0418
vect: 8663446 decicycles in eq, 2048 runs, 0 skips CRC=0xb4a713e1
Note: vect is -O3 -msse4.2 -ftree-vectorize

-- 
Christophe