[FFmpeg-devel] [PATCH] Port mp=eq/eq2 to FFmpeg

[wm4]

On Mon, 19 Jan 2015 16:23:46 +0100
Stefano Sabatini <stefasab at gmail.com> wrote:

> On date Monday 2015-01-19 15:20:54 +0100, Clément Bœsch encoded:
> > On Mon, Jan 19, 2015 at 02:09:33PM +0000, Paul B Mahol wrote:
> > > On 1/18/15, arwa arif <arwaarif1994 at gmail.com> wrote:
> > > > Attached the patch.
> > > >
> > > 
> > > I'm for dropping eq code and rename eq2 to eq.
> > 
> > Yes please let's not add 2 filters for this, it's insane. Also, "eq" is
> > quite a bad name, but well...
> > 
> 
> > What happened to the idea of having the feature in hue instead?
> 
> I'm not against that if we agree it's a better path.
> 
> About eq/eq2, are there really performance concerns for having both of
> them? 
> 
> Arwa, can you show some benchmarks?

Why are you questioning this again? vf_eq2 is vf_eq copy&pasted, with
exactly the same asm, and an additional _optional_ code path using a
LUT. This extra code path is not taken when using it like vf_eq.

(Did you think mplayer development made sense?)