[FFmpeg-devel] [PATCH] nvenc: Compensate for hardware trying to mess with aspect ratio of DVD content.

[Nicolas George]

L'octidi 28 nivôse, an CCXXIII, Kieran Kunhya a écrit :
> I don't make the standards and frankly whether you dislike them is
> your problem but they exist and need to work correctly.
> Instead you wish to break things based off an artificial test pattern
> and your own beliefs.

I do not wish to break things, I wish to fix them correctly.

The so-called fix in nvenc is completely wrong, because it happens at the
wrong place: it introduces exceptional cases, it violates the rules of
arithmetic, it is not documented, it affects cases that should be left alone
and misses cases it should handle, it behaved differently than other parts
of the code. Is it enough, or do you need more reasons?

If the aspect ratio needs to be fixed, it must happen as soon as the video
enters FFmpeg, i.e. at the demuxer or decoder level. Any other place is
wrong.

As is, Philip's patch fixes nvenc's misbehaviour, making it consistent with
arithmetic and other encoders: the latest version should be applied soon.
You, or anyone else who knows what they are doing, can file another patch to
properly fix the issue, if it happens there is anything to fix.

Regards,

-- 
  Nicolas George
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <https://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20150118/2c10dc5e/attachment.asc>