[FFmpeg-devel] [PATCH] movenc: Write 'colr' box correctly for MP4

[Clément Bœsch]

On Thu, Feb 26, 2015 at 01:47:01PM +0000, Derek Buitenhuis wrote:
> This also restricts it to MOV and MP4, since it is only
> defined for those formats.
> 
> Signed-off-by: Derek Buitenhuis <derek.buitenhuis at gmail.com>
> ---
>  libavformat/movenc.c | 29 +++++++++++++++++++++++------
>  1 file changed, 23 insertions(+), 6 deletions(-)
> 
> diff --git a/libavformat/movenc.c b/libavformat/movenc.c
> index 210f78e..9c6e1be 100644
> --- a/libavformat/movenc.c
> +++ b/libavformat/movenc.c
[...]
> +    if (mov->flags & FF_MOV_FLAG_WRITE_COLR) {
> +        if (track->mode == MODE_MOV || track->mode == MODE_MP4)
> +            mov_write_colr_tag(pb, track);
> +        else
> +            av_log(mov->fc, AV_LOG_WARNING, "Not writing 'colr' atom. Format is not MOV or MP4.\n");

If the option is set by default, you don't want to warn for no reason.

-- 
Clément B.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 473 bytes
Desc: not available
URL: <https://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20150226/063dd460/attachment.asc>