[FFmpeg-devel] [PATCH] avformat: Add simple ACLR atom reading to set the color range

Michael Niedermayer michaelni at gmx.at
Tue Feb 17 13:25:46 CET 2015

On Tue, Feb 17, 2015 at 11:58:06AM +0000, Kevin Wheatley wrote:
> Oops, I missed that when I allowed the atom to be added to the end of
> the extradata, updated.
> I'm not sure if logging as an error is appropriate in the case when
> the extradata is not large enough, for this to occur the file will
> have been truncated somehow and the mov_read_extradata function will
> have logged a warning and returned 0. Which at first glance seams
> wrong - should mov_read_extradata return something other than 0 in
> this case?
> Either way it does mean the code could read the wrong value, but
> should not crash with the guard in place.

if the codec id doesnt match the expected, mov_read_extradata will
return 0 even without any truncation.
In this case the error message would be incorrect


Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

The worst form of inequality is to try to make unequal things equal.
-- Aristotle
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 181 bytes
Desc: Digital signature
URL: <https://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20150217/561b4ae4/attachment.asc>

More information about the ffmpeg-devel mailing list