[FFmpeg-devel] [PATCH] ffprobe: Force string_validation to int type, its accessed via AVOption as int

Clément Bœsch u at pkh.me
Mon Feb 9 01:44:43 CET 2015


On Fri, Feb 06, 2015 at 10:10:22PM +0100, Michael Niedermayer wrote:
> Signed-off-by: Michael Niedermayer <michaelni at gmx.at>
> ---
>  ffprobe.c |    3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/ffprobe.c b/ffprobe.c
> index d352bb6b..8617c96 100644
> --- a/ffprobe.c
> +++ b/ffprobe.c
> @@ -294,7 +294,8 @@ typedef enum {
>      WRITER_STRING_VALIDATION_FAIL,
>      WRITER_STRING_VALIDATION_REPLACE,
>      WRITER_STRING_VALIDATION_IGNORE,
> -    WRITER_STRING_VALIDATION_NB
> +    WRITER_STRING_VALIDATION_NB,
> +    WRITER_STRING_VALIDATION_FORCE_ENUM_TO_INT_TYPE= 0x76543210,
>  } StringValidation;
>  

I prefer the int approach you originally proposed. This hack makes me
quite uncomfortable, and the idea of having it all over the code base as
well.

-- 
Clément B.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 473 bytes
Desc: not available
URL: <https://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20150209/b78b7e36/attachment.asc>


More information about the ffmpeg-devel mailing list