[FFmpeg-devel] [PATCH 2/2] new option for drawtext (boxborderw = set box border width)

[Liviu Oniciuc]

it is not related with the inside padding, and yes it does try to follow the
css/ffmpeg vocabulary. 'boxborderw' refer to what css names: 'border-width',
but ffmpeg drawtext already has a 'borderw' option, that is actually 
used for what
css will call: font-weight. to be close to css, but not brake the 
already existing
naming convention for 'draxtext' I chose 'boxborderw'
I could have renamed the existing 'borderw' to a more close description 
'fontw',
but it would have been against policy#6 of ffmpeg '1.4 Development Policy'
i did test this option for single and multiline overlay text, and for 
cases were the
text offset is smaller then the border size
<sorry if duplicate, may have some trouble with the email client?>
LiviuO


On 2/4/2015 1:13 PM, Clément Bœsch wrote:
> On Tue, Feb 03, 2015 at 09:01:30AM -0800, Liviu Oniciuc wrote:
>> at this time the drawtext box extends only for the width and height
>> of the text. for a better visual appearance a new option was added
>> (boxboderw) to set how much the box should extend outside of the
> boxborderw
>
>> text area
>>
>> Signed-off-by: Liviu Oniciuc <klmno.dev at gmx.com>
>> ---
>>   libavfilter/vf_drawtext.c | 6 +++++-
>>   1 file changed, 5 insertions(+), 1 deletion(-)
>>   mode change 100644 => 100755 libavfilter/vf_drawtext.c
>>
>> diff --git a/libavfilter/vf_drawtext.c b/libavfilter/vf_drawtext.c
>> old mode 100644
>> new mode 100755
>> index d20f805..138a32c
>> --- a/libavfilter/vf_drawtext.c
>> +++ b/libavfilter/vf_drawtext.c
>> @@ -159,6 +159,7 @@ typedef struct DrawTextContext {
>>       unsigned int fontsize;          ///< font size to use
>>   
>>       short int draw_box;             ///< draw box around text - true or false
>> +    int boxborderw;                 ///< box border width
> So is this related to an inside padding? Could we try to stick a bit with
> the CSS vocabulary so people can get the meaning faster?
>
>
>
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel at ffmpeg.org
> http://ffmpeg.org/mailman/listinfo/ffmpeg-devel