[FFmpeg-devel] [PATCH] lavf/matroskadec.c: Copy QuickTime palette to st->codec->extradata

Mats Peterson matsp888 at yahoo.com
Tue Dec 29 04:00:42 CET 2015


On 12/29/2015 03:23 AM, Mats Peterson wrote:
> In case this patch got lost in my endless stream of previous posts, I'll
> repost it. Description of the patch follows:
>
> In order to make MPlayer use the correct palette when playing palettized
> QuickTime video in Matroska, the palette will need to be copied to
> st->codec->extradata in matroskadec.c. As I have explained so many times
> before, for some inexplicable reason, MPlayer in its current state adds
> *another* palette side data packet *after* the one added in
> matroskadec.c, using whatever is in extradata as the palette.
>
> Since this copying to st->codec->extradata is done for V_MS/VFW/FOURCC,
> I see no reason why it couldn't be done for V_QUICKTIME as well. I have
> yet to see any program use the extradata for anything else than the
> palette when it comes to palettized video in Matroska. I might be wrong,
> of course.
>
> If this patch is not acceptable, we'll have to tell the MPlayer
> maintainers to fix this extraneous addition of yet another palette side
> data packet. Unfortunately, in my experience, they seem rather slow on
> reacting. I would therefore be grateful if someone of the more
> "influential" persons here could bring this issue up in their community.
>
> Sample palettized Matroska files for testing are available at
> https://drive.google.com/open?id=0B3_pEBoLs0faWElmM2FnLTZYNlk.
>
> Mats
>
>
>
>
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel at ffmpeg.org
> http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>

Well, what do you know. It seems the issue has already been fixed in 
MPlayer. I just recompiled it with the latest FFmpeg. Black magic. 
Forget this patch then.

Mats

-- 
Mats Peterson
http://matsp888.no-ip.org/~mats/


More information about the ffmpeg-devel mailing list