[FFmpeg-devel] [PATCH 1/5] lavfi/vf_hue: replace rint by lrint

[Michael Niedermayer]

On Fri, Dec 25, 2015 at 04:00:16PM -0800, Ganesh Ajjanagadde wrote:
> avoids float to int cast, and is slightly superior in terms of rounding
> ("Dutch/Gauss rounding").
> 
> Signed-off-by: Ganesh Ajjanagadde <gajjanagadde at gmail.com>
> ---
>  libavfilter/vf_hue.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/libavfilter/vf_hue.c b/libavfilter/vf_hue.c
> index 2c1b34e..92607f1 100644
> --- a/libavfilter/vf_hue.c
> +++ b/libavfilter/vf_hue.c
> @@ -105,8 +105,8 @@ static inline void compute_sin_and_cos(HueContext *hue)
>       * the saturation.
>       * This will be useful in the apply_lut function.
>       */
> -    hue->hue_sin = rint(sin(hue->hue) * (1 << 16) * hue->saturation);
> -    hue->hue_cos = rint(cos(hue->hue) * (1 << 16) * hue->saturation);
> +    hue->hue_sin = lrint(sin(hue->hue) * (1 << 16) * hue->saturation);
> +    hue->hue_cos = lrint(cos(hue->hue) * (1 << 16) * hue->saturation);

the change LGTM

thx

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

The worst form of inequality is to try to make unequal things equal.
-- Aristotle
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 181 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20151226/9dd59ff5/attachment.sig>