[FFmpeg-devel] [PATCH] ffplay: replace rint by lrint

[Ronald S. Bultje]

Hi,

On Fri, Dec 25, 2015 at 2:29 PM, Ganesh Ajjanagadde <gajjanagadde at gmail.com>
wrote:

> avoids the float to integer cast, and is slightly superior in terms of
> rounding ("Dutch/Gauss rounding").
>
> Signed-off-by: Ganesh Ajjanagadde <gajjanagadde at gmail.com>
> ---
>  ffplay.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/ffplay.c b/ffplay.c
> index 2f8a0bf..9256392 100644
> --- a/ffplay.c
> +++ b/ffplay.c
> @@ -927,10 +927,10 @@ static void calculate_display_rect(SDL_Rect *rect,
>
>      /* XXX: we suppose the screen has a 1.0 pixel ratio */
>      height = scr_height;
> -    width = ((int)rint(height * aspect_ratio)) & ~1;
> +    width = (lrint(height * aspect_ratio)) & ~1;
>      if (width > scr_width) {
>          width = scr_width;
> -        height = ((int)rint(width / aspect_ratio)) & ~1;
> +        height = (lrint(width / aspect_ratio)) & ~1;
>      }


You can actually remove one more set of brackets. Patch itself probably OK.

Ronald