[FFmpeg-devel] [PATCH] avcodec: add OpenJPEG 2.x compatibility

[Ronald S. Bultje]

Hi,

On Thu, Dec 24, 2015 at 5:09 PM, Michael Bradshaw <mjbshaw at gmail.com> wrote:

> On Thu, Nov 19, 2015 at 6:31 PM, Michael Niedermayer <michaelni at gmx.at>
> wrote:
>
> > On Wed, Nov 18, 2015 at 09:22:57PM -0800, Michael Bradshaw wrote:
> > > On Wed, Nov 18, 2015 at 8:00 AM, Michael Niedermayer
> > <michael at niedermayer.cc
> > > > wrote:
> > >
> > > > On Tue, Nov 17, 2015 at 07:27:55AM -0800, Michael Bradshaw wrote:
> > > > > Hi,
> > > > >
> > > > > Attached patch adds support for OpenJPEG 2.0/2.1. Please review.
> > > > >
> > > > > Thanks,
> > > > >
> > > > > Michael Bradshaw
> > > >
> > > > >  configure                   |    5
> > > > >  libavcodec/libopenjpegdec.c |  173 ++++++++++++++++++++++++----
> > > > >  libavcodec/libopenjpegenc.c |  269
> > > > +++++++++++++++++++++++++++++++++++++-------
> > > > >  3 files changed, 382 insertions(+), 65 deletions(-)
> > > > > 4e7c94ca16fa09210c4d74a4cf589ae9db540e9a
> > > > 0001-avcodec-add-OpenJPEG-2.x-compatibility.patch
> > > > > From 1cdf996b7fdaed429731054e96f9e6b565c9436d Mon Sep 17 00:00:00
> > 2001
> > > > > From: Michael Bradshaw <mjbshaw at google.com>
> > > > > Date: Sun, 1 Nov 2015 19:11:12 -0800
> > > > > Subject: [PATCH] avcodec: add OpenJPEG 2.x compatibility
> > > >
> > > > this seems breaking the decoder
> > > >
> > > > ./ffmpeg -i matrixbench_mpeg2.mpg  -vcodec libopenjpeg -vframes 1
> > test.j2k
> > > >
> > > > ./ffmpeg -strict -2 -vcodec libopenjpeg -i test.j2k -f null -
> > > >
> > > > [libopenjpeg @ 0x28f3220] Error decoding codestream header.
> > > > [j2k_pipe @ 0x28d1bc0] decoding for stream 0 failed
> > > > [j2k_pipe @ 0x28d1bc0] Could not find codec parameters for stream 0
> > > > (Video: jpeg2000, none): unspecified size
> > > > Consider increasing the value for the 'analyzeduration' and
> 'probesize'
> > > > options
> > > > test.j2k: could not find codec parameters
> > >
> > >
> > > Oops, misplaced a ! in some last minute cleanup. Fixed patch attached.
> >
> > >  configure                   |    5
> > >  libavcodec/libopenjpegdec.c |  173 ++++++++++++++++++++++++----
> > >  libavcodec/libopenjpegenc.c |  269
> > +++++++++++++++++++++++++++++++++++++-------
> > >  3 files changed, 382 insertions(+), 65 deletions(-)
> > > dc1ec76dc92d0a03c8fec0d4c14228e14f1c4e1e
> > 0001-avcodec-add-OpenJPEG-2.x-compatibility.patch
> > > From 2fff5b8f6832d93ae65a75953db842c3fe6d9e86 Mon Sep 17 00:00:00 2001
> > > From: Michael Bradshaw <mjbshaw at google.com>
> > > Date: Sun, 1 Nov 2015 19:11:12 -0800
> > > Subject: [PATCH] avcodec: add OpenJPEG 2.x compatibility
> >
> > should i apply this ?
> > (it seems working, but it seems some people where nt entirely happy
> >  are there objectiosn remaiing after Michael Bradshaws replies?)
> >
>
> No objections from anyone, I assume?


No objections.

Ronald