[FFmpeg-devel] [PATCH v5] lavf: palettized QuickTime video in Matroska

[Mats Peterson]

On 12/23/2015 01:37 PM, Mats Peterson wrote:
> On 12/23/2015 01:33 PM, Hendrik Leppkes wrote:
>> Am 23.12.2015 13:28 schrieb "Mats Peterson" <
>> matsp888-at-yahoo.com at ffmpeg.org>:
>>>
>>> On 12/23/2015 01:15 PM, Mats Peterson wrote:
>>>>
>>>> On 12/23/2015 01:13 PM, Carl Eugen Hoyos wrote:
>>>>>
>>>>> Mats Peterson <matsp888-at-yahoo.com <at> ffmpeg.org> writes:
>>>>>
>>>>>>>> In matroskadec.c, I'm also putting the palette in 'extradata',
>>>>>>>> like it's done for V_MS/VFW/FOURCC; this is a requirement in
>>>>>>>> order for MPlayer to recognize the palette.
>>>>>>>
>>>>>>>
>>>>>>> This is wrong, please remove this hunk.
>>>>>
>>>>>
>>>>>> The reason for this is because MPlayer won't notice the
>>>>>> palette otherwise, as I said before.
>>>>>
>>>>>
>>>>> This is not correct.
>>>>>
>>>>>> Try it yourself.
>>>>>
>>>>>
>>>>> Please do.
>>>>>
>>>>> Carl Eugen
>>>>>
>>>>> _______________________________________________
>>>>> ffmpeg-devel mailing list
>>>>> ffmpeg-devel at ffmpeg.org
>>>>> http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>>>>>
>>>>
>>>> Stop this meaningless rant until you've tried it. I know more about
>>>> this
>>>> issue than you do.
>>>>
>>>> Mats
>>>>
>>>
>>> Let me once and for all clarify the issue with MPlayer and the palette
>> for you, Eugen. The palette side data packet is sent alright in
>> matroskadec.c, the problem is that MPlayer sends ANOTHER palette side
>> data
>> AFTERWARDS, using whatever is in extradata as the palette. Complain at
>> the
>> authors of MPlayer, not me.
>>>
>>
>> If anything it sounds like a bug in mplayer, not FFmpeg.
>> _______________________________________________
>> ffmpeg-devel mailing list
>> ffmpeg-devel at ffmpeg.org
>> http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>>
>
> Well, before my patch, there was no palette side data packet sent
> whatsoever in matroskadec.c, as I have clearly stated in the description
> of the patch. But the issue with MPlayer is unrelated to that. The
> problem is that MPlayer insists on sending another palette side data
> packet afterwards. That's where things mess up. You're forced to place
> the palette in extradata AS WELL in order to make MPlayer use
> it properly when it sends it extraneous palette side data packet.
>
> Mats
>

Ouch, I noticed a mistake here. New patch on its way.

Mats

-- 
Mats Peterson
http://matsp888.no-ip.org/~mats/