[FFmpeg-devel] [PATCH] avcodec/s302menc: set supported channel layouts by codec

Paul B Mahol onemda at gmail.com
Tue Dec 22 21:09:45 CET 2015


On 12/22/15, Kieran Kunhya <kierank at obe.tv> wrote:
> On 20 December 2015 at 00:14, Michael Niedermayer
> <michael at niedermayer.cc> wrote:
>> On Sat, Dec 19, 2015 at 09:35:19PM +0100, Paul B Mahol wrote:
>>> Signed-off-by: Paul B Mahol <onemda at gmail.com>
>>> ---
>>>  libavcodec/s302menc.c | 5 +++++
>>>  1 file changed, 5 insertions(+)
>>>
>>> diff --git a/libavcodec/s302menc.c b/libavcodec/s302menc.c
>>> index fbaa845..3706eba 100644
>>> --- a/libavcodec/s302menc.c
>>> +++ b/libavcodec/s302menc.c
>>> @@ -175,4 +175,9 @@ AVCodec ff_s302m_encoder = {
>>>
>>> AV_SAMPLE_FMT_NONE },
>>>      .capabilities          = AV_CODEC_CAP_VARIABLE_FRAME_SIZE |
>>> AV_CODEC_CAP_EXPERIMENTAL,
>>>      .supported_samplerates = (const int[]) { 48000, 0 },
>>> +    .channel_layouts       = (const uint64_t[]) { AV_CH_LAYOUT_STEREO,
>>> +                                                  AV_CH_LAYOUT_QUAD,
>>> +
>>> AV_CH_LAYOUT_5POINT1_BACK,
>>> +
>>> AV_CH_LAYOUT_5POINT1_BACK | AV_CH_LAYOUT_STEREO_DOWNMIX,
>>> +                                                  0 },
>>
>> assuming the list is correct, the patch LGTM
>
> This list is incorrect, please revert the patch.

This is what decoder sets. What it should be instead?


More information about the ffmpeg-devel mailing list