[FFmpeg-devel] [PATCH] Revert "Merge commit '741b494fa8cd28a7d096349bac183893c236e3f9'"

Ronald S. Bultje rsbultje at gmail.com
Thu Dec 17 15:25:46 CET 2015


Hi,

On Thu, Dec 17, 2015 at 8:46 AM, Hendrik Leppkes <h.leppkes at gmail.com>
wrote:

> Reverting big commits to fix one sample and making future merges
> harder or impossible seems not like the best option, unless it can be
> shown that the entire change is flawed, and not just a small bug.
> Otherwise, it should be attempted to fix regressions the usual way -
> by fixing things, not reverting.


So, it seems (from a cursory look) that the change basically removed the
possibility to introduce a "default" ref (from the pps) if the actual ref
(from the slicehdr) is missing (e.g. dropped frames or so). I'm not sure
why we specifically want a default ref here, why not just take the one with
the nearest poc value instead? (That's what openhevc's code does.)

Ronald


More information about the ffmpeg-devel mailing list