[FFmpeg-devel] [PATCH] on2avc: limit number of bits to 30 in get_egolomb

[Michael Niedermayer]

On Wed, Dec 16, 2015 at 08:20:18PM +0100, Andreas Cadhalpun wrote:
> More don't fit into the integer output.
> 
> Also use get_bits_long, since get_bits only supports reading up to 25
> bits, while get_bits_long supports the full integer range.
> 
> Signed-off-by: Andreas Cadhalpun <Andreas.Cadhalpun at googlemail.com>
> ---
>  libavcodec/on2avc.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/libavcodec/on2avc.c b/libavcodec/on2avc.c
> index 15f4dd1..10861b5 100644
> --- a/libavcodec/on2avc.c
> +++ b/libavcodec/on2avc.c
> @@ -211,9 +211,9 @@ static inline int get_egolomb(GetBitContext *gb)
>  {
>      int v = 4;
>  
> -    while (get_bits1(gb)) v++;
> +    while (get_bits1(gb) && v < 30) v++;

it could make sense to print a warning or error in case its too long

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Good people do not need laws to tell them to act responsibly, while bad
people will find a way around the laws. -- Plato
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 181 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20151217/0fd156f4/attachment.sig>