[FFmpeg-devel] [PATCH] lavu/frame: Optimize frame_copy_video

Jean Delvare jdelvare at suse.de
Tue Dec 15 18:23:53 CET 2015


On Tue, 15 Dec 2015 16:56:02 +0000, Derek Buitenhuis wrote:
> On 12/15/2015 10:44 AM, Jean Delvare wrote:
> > Originally I proposed this patch for performance reasons and also
> > because I think it makes the code more readable. But seeing how the
> > same cast is already present everywhere in the ffmpeg code, I would now
> > also invoke consistency. There's no rationale for not doing the same
> > here that is already done everywhere else. If it caused any problem we
> > would know by now (and I verified that this patch passes the test
> > suite, FWIW.)
> 
> I'd argue we should fix those instead. Some work on that has already been done,
> such as 60392480181f24ebf3ab48d8ac3614705de90152.

Looks like something different from what we were discussing here.

-- 
Jean Delvare
SUSE L3 Support


More information about the ffmpeg-devel mailing list