[FFmpeg-devel] [PATCH 1/2] lavu: add AVVideoFramePool

[Matthieu Bouron]

On Sun, Dec 13, 2015 at 12:51 AM, Michael Niedermayer <michaelni at gmx.at>
wrote:

> On Fri, Dec 11, 2015 at 07:35:08PM +0100, Matthieu Bouron wrote:
> > On Fri, Dec 11, 2015 at 7:07 PM, Michael Niedermayer <michaelni at gmx.at>
> > wrote:
> >
> > > On Fri, Dec 11, 2015 at 01:32:46PM +0100, Matthieu Bouron wrote:
> > > > From: Matthieu Bouron <matthieu.bouron at stupeflix.com>
> > > >
> > > > ---
> > > >  libavutil/frame.c          | 153
> > > +++++++++++++++++++++++++++++++++++++++++++++
> > > >  libavutil/frame.h          |  56 +++++++++++++++++
> > > >  libavutil/frame_internal.h |  37 +++++++++++
> > > >  3 files changed, 246 insertions(+)
> > > >  create mode 100644 libavutil/frame_internal.h
> > >
> > >
> > > make distclean ; ./configure --enable-shared --cc=clang && make -j12
> > >
> > > in file included from libavutil/frame.c:26:
> > > libavutil/frame_internal.h:35:3: error: redefinition of typedef
> > > 'AVVideoFramePool' is invalid in C [-Wtypedef-redefinition]
> > > } AVVideoFramePool;
> > >   ^
> > > libavutil/frame.h:718:33: note: previous definition is here
> > > typedef struct AVVideoFramePool AVVideoFramePool;
> > >                                 ^
> > > 1 error generated.
> > > make: *** [libavutil/frame.o] Error 1
> > > make: *** Waiting for unfinished jobs....
> > >
> > >
> > Fixed, new patch attached.
> >
> > Thanks.
> >
> > [...]
>
> >  frame.c          |  153
> +++++++++++++++++++++++++++++++++++++++++++++++++++++++
> >  frame.h          |   56 ++++++++++++++++++++
> >  frame_internal.h |   37 +++++++++++++
> >  3 files changed, 246 insertions(+)
> > bf36a47628ee66ed76ab19dd412b97c88cb639bd
> 0001-lavu-add-AVVideoFramePool.patch
> > From 1d8bd643699f78cea70e647cc584b012d9d77df1 Mon Sep 17 00:00:00 2001
> > From: Matthieu Bouron <matthieu.bouron at stupeflix.com>
> > Date: Fri, 11 Dec 2015 09:55:27 +0100
> > Subject: [PATCH 1/2] lavu: add AVVideoFramePool
>
> seems fine to me
>

I think it is better to have this API private for now until it is able to
cover both audio and video and it can replace libavcodec/FramePool.
I've updated the lavfi patch to include this API (renamed to
FFVideoFramePool) so it can evolve there until it is ready to be public.

Matthieu
[...]