[FFmpeg-devel] [PATCH] matroskadec.c: Handle palettized QuickTime video properly

[Mats Peterson]

Well, it's more or less an impossibility that anything will break from using 36 instead 86, since as I said before, 36 is the size of a version 0 sound sample description, which is rather old, but should of course still be recognized in FFmpeg. Let me refer to the QuickTime File Format Reference for additional info.

Mats -- 
Mats Peterson
http://matsp888.no-ip.org/~mats/
      From: compn <tempn at mi.rr.com>
 To: FFmpeg development discussions and patches <ffmpeg-devel at ffmpeg.org> 
 Sent: Friday, December 11, 2015 3:08 PM
 Subject: Re: [FFmpeg-devel] [PATCH] matroskadec.c: Handle palettized QuickTime video properly
   
On Fri, 11 Dec 2015 12:59:16 +0000 (UTC)
Mats Peterson <matsp888-at-yahoo.com at ffmpeg.org> wrote:

> I just want someone of you guys to take a look at what I've done. You
> know Git much better than me, and you can create a pull request it
> looks decent enough. I'm not going to participate a lot in this in
> the future, but I wanted to correct these things, since they have
> been overlooked for such a long time. Mats -- Mats Peterson

thanks for contributing. 

it can be daunting for new contributors to follow all of our arcane
rules.

anyone can split up patches, just using diff -u and a couple new files.
doesnt have to be done with git.

you've done your job, the patch is submitted. 

a question about changing the a_quicktime limit is did you test a bunch
of other a_quicktime samples to make sure nothing broke?  thats always
fun when changing things is that we have to retest all other samples we
have from http://samples.ffmpeg.org . not sure we even have that many
a_quicktime in mkv samples. same with v_quicktime.

-compn


_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel at ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel