[FFmpeg-devel] [PATCH] avformat/mov: Enable parser for mp3s by old HandBrake
Moritz Barsnick
barsnick at gmx.net
Thu Dec 10 10:37:42 CET 2015
On Wed, Dec 09, 2015 at 22:24:08 +0100, Michael Niedermayer wrote:
> + if (sscanf(str, "HandBrake %d.%d.%d", &major, &minor, µ) == 3) {
> + c->handbrake_version = 1000000*major + 1000*minor + micro;
[...]
> + if (mov->handbrake_version &&
> + mov->handbrake_version <= 1000000*0 + 1000*10 + 0 &&
Really hard to read for all the '1's and '0'. You're checking for "<=
0.10.0"? Perhaps better to clearly document that.
So starting with 0.10.1, behavior is different?
Moritz
More information about the ffmpeg-devel
mailing list