[FFmpeg-devel] [PATCH] avcodec/h264: Set CORRUPT flag on output frames that are not fully recovered

[Michael Niedermayer]

On Mon, Dec 07, 2015 at 11:06:38AM +0200, Sebastian Dröge wrote:
> From: Sebastian Dröge <sebastian at centricular.com>
> 
> In the merge commit 78265fcfeee153e5e26ad4dbc7831a84ade447d6 this behaviour
> was broken and the CORRUPT flag would never ever be set on a frame. However
> the flag on the AVCodecContext was taken into account properly, including
> AV_CODEC_FLAG2_SHOW_ALL.
> 
> The reason for this was that the recovered field of the next output picture
> was always set to TRUE whenever one of the two AVCodecContext flags was set,
> which made it impossible to detect later, before outputting, if the frame was
> really recovered or not. Now don't set it to TRUE unless the frame is really
> recovered and check the AVCodecContext flags right before outputting.
> 
> Signed-off-by: Sebastian Dröge <sebastian at centricular.com>
> ---
>  libavcodec/h264.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)

this breaks "-flags2 showall", many (ugly) frames are no longer shown
one sample showing this is:
https://docs.google.com/file/d/0BxP5-S1t9VEEY3RqUmg3NHk3aEE/edit?usp=drive_web

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Complexity theory is the science of finding the exact solution to an
approximation. Benchmarking OTOH is finding an approximation of the exact
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 181 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20151208/a40c461a/attachment.sig>