[FFmpeg-devel] [PATCH v3 14/14] mips: display a warning message when using an unknown CPU

[Andreas Cadhalpun]

Hi Vicente,

On 04.12.2015 16:12, Vicente Olivert Riera wrote:
> On 04/12/15 14:32, Andreas Cadhalpun wrote:
>> On 03.12.2015 14:22, Vicente Olivert Riera wrote:
>>> --- a/configure
>>> +++ b/configure
>>> @@ -4163,6 +4163,8 @@ elif enabled mips; then
>>>              # the unwanted features.
>>>          ;;
>>>          *)
>>> +            # Unknown CPU. Disable everything.
>>> +            echo "Warning: unknown CPU. All features disabled by default."
>>
>> This sounds strange. I'd rather say:
>> 'Warning: unknown CPU. Disabling all mips optimizations.'
>>
>> Otherwise looks good.
> 
> is the first time I contribute to ffmpeg. Does that issue needs a
> re-spin of the 13 patch series,

I don't think so.
You could just use git format-patch and attach the relevant one in a reply.

> or is it something that the maintainer can do for me when applying the patch?

Maybe, but there's no guarantee that the committer remembers doing it.

Best regards,
Andreas