[FFmpeg-devel] [PATCH] aacenc_ltp: attempt to appease Coverity
Hendrik Leppkes
h.leppkes at gmail.com
Thu Dec 3 23:51:03 CET 2015
On Thu, Dec 3, 2015 at 11:31 PM, Rostislav Pehlivanov
<atomnuker at gmail.com> wrote:
> Coverity is reporting an out of bounds here even though there shouldn't
> be one. Attempt to apply some stylistic dithering to make it stop.
> ---
> libavcodec/aacenc_ltp.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/libavcodec/aacenc_ltp.c b/libavcodec/aacenc_ltp.c
> index e19f3cc..0f449de 100644
> --- a/libavcodec/aacenc_ltp.c
> +++ b/libavcodec/aacenc_ltp.c
> @@ -167,7 +167,7 @@ void ff_aac_search_for_ltp(AACEncContext *s, SingleChannelElement *sce,
>
> if (sce->ics.window_sequence[0] == EIGHT_SHORT_SEQUENCE) {
> if (sce->ics.ltp.lag) {
> - memset(&sce->lcoeffs[0], 0.0f, 3072*sizeof(sce->lcoeffs[0]));
> + memset(sce->lcoeffs, 0, 3072*sizeof(sce->lcoeffs[0]));
> memset(&sce->ics.ltp, 0, sizeof(LongTermPrediction));
> }
> return;
> --
lcoeffs is only 1024 elements, so it appears coverity is right? :)
- Hendrik
More information about the ffmpeg-devel
mailing list