[FFmpeg-devel] [PATCH] aacenc: mark coders other than twoloop as experimental

[Rostislav Pehlivanov]

Any opposition?

On 2 December 2015 at 19:47, Rostislav Pehlivanov <atomnuker at gmail.com>
wrote:

> This commit marks any coders beside twoloop as experimental and gives
> out a warning that some of they might be silently removed in the future.
>
> Users are highly encouraged to use the twoloop coder, which is the
> default.
> ---
>  libavcodec/aacenc.c | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/libavcodec/aacenc.c b/libavcodec/aacenc.c
> index 971f8ab..7a34806 100644
> --- a/libavcodec/aacenc.c
> +++ b/libavcodec/aacenc.c
> @@ -967,6 +967,8 @@ static av_cold int aac_encode_init(AVCodecContext
> *avctx)
>      s->coder = &ff_aac_coders[s->options.coder];
>
>      if (s->options.coder != AAC_CODER_TWOLOOP) {
> +        ERROR_IF(avctx->strict_std_compliance >
> FF_COMPLIANCE_EXPERIMENTAL,
> +                 "Coders other than twoloop require -strict -2 and some
> may be removed in the future\n");
>          s->options.intensity_stereo = 0;
>          s->options.pns = 0;
>      }
> --
> 2.6.2
>
>