[FFmpeg-devel] [PATCH 3/5] lavfi: deprecate avfilter_link_set_closed().

Andreas Cadhalpun andreas.cadhalpun at googlemail.com
Wed Dec 2 19:02:25 CET 2015


On 29.11.2015 17:21, Nicolas George wrote:
> Applications are not supposed to mess with links,
> they should close the sinks.
> Furthermore, this function does not distinguish what end
> of the link caused the close and does not have a timestamp.
> 
> Signed-off-by: Nicolas George <george at nsup.org>
> ---
>  libavfilter/avfilter.h | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/libavfilter/avfilter.h b/libavfilter/avfilter.h
> index a6aa919..58a0cbd 100644
> --- a/libavfilter/avfilter.h
> +++ b/libavfilter/avfilter.h
> @@ -541,7 +541,10 @@ int avfilter_link_get_channels(AVFilterLink *link);
>  
>  /**
>   * Set the closed field of a link.
> + * @deprecated applications are not supposed to mess with links, they should
> + * close the sinks.
>   */
> +attribute_deprecated
>  void avfilter_link_set_closed(AVFilterLink *link, int closed);
>  
>  /**
> 

It would be nice to mention this deprecation in APIchanges.
Other than that, this deprecation should be fine, as there seem to be no users
of this function.

Best regards,
Andreas


More information about the ffmpeg-devel mailing list