[FFmpeg-devel] [FFmpeg-cvslog] disable deprecation warnings in deprecated code

Michael Niedermayer michael at niedermayer.cc
Sun Aug 23 19:58:15 CEST 2015


On Sun, Aug 23, 2015 at 11:24:06AM +0200, Andreas Cadhalpun wrote:
> On 23.08.2015 11:05, Hendrik Leppkes wrote:
> > On Sun, Aug 23, 2015 at 10:51 AM, Andreas Cadhalpun
> >> So instead of including that, one can copy the definition of the
> >> FF_{DIS,EN}ABLE_DEPRECATION_WARNINGS macros, see attached patch.
> >>
> >> Alternatively one could just revert the changes to libavcodec/options_table.h
> >> and ignore the warnings in that file.
> > 
> > Copying the macros is unnecessary bloat. Either just enable the
> > warnings there again,
> 
> OK, patch for that attached.
> 
> > or hack around in print_options.c to make it
> > avoid the error in other ways.
> 
> I don't think that's worth the trouble.
> 
> Best regards,
> Andreas
> 

>  options_table.h |    3 ---
>  1 file changed, 3 deletions(-)
> a47e74fd475ff47b15f37f0c9caabf354f82c8e3  0001-options_table-fix-compatibility-with-MSVC.patch
> From 96592b50ea0b1d050a7f95166653e742306897d3 Mon Sep 17 00:00:00 2001
> From: Andreas Cadhalpun <Andreas.Cadhalpun at googlemail.com>
> Date: Sun, 23 Aug 2015 11:16:10 +0200
> Subject: [PATCH] options_table: fix compatibility with MSVC
> 
> Including libavutil/internal.h breaks compilation of doc/print_options.c
> with MSVC due to linking avpriv_strtod/avpriv_snprintf.
> 
> This reverts part of commit 095347f.

LGTM

[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Avoid a single point of failure, be that a person or equipment.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 181 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20150823/1a905fe2/attachment.sig>


More information about the ffmpeg-devel mailing list