[FFmpeg-devel] [PATCHv2] avdevice/lavfi: fix self assignment warning

Ganesh Ajjanagadde gajjanagadde at gmail.com
Sun Aug 23 05:26:36 CEST 2015


On Sat, Aug 22, 2015 at 11:24 PM, Ganesh Ajjanagadde
<gajjanagadde at gmail.com> wrote:
> FAIL(ret) expands to statements including a silly ret=ret.
> This triggers a -Wself-assign on confirmed clang 3.6, and so we fix it.
>
> Signed-off-by: Ganesh Ajjanagadde <gajjanagadde at gmail.com>
> ---
>  libavdevice/lavfi.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/libavdevice/lavfi.c b/libavdevice/lavfi.c
> index d92e299..3453b4d 100644
> --- a/libavdevice/lavfi.c
> +++ b/libavdevice/lavfi.c
> @@ -337,7 +337,7 @@ av_cold static int lavfi_read_header(AVFormatContext *avctx)
>      }
>
>      if ((ret = create_subcc_streams(avctx)) < 0)
> -        FAIL(ret);
> +        goto end;
>
>      if (!(lavfi->decoded_frame = av_frame_alloc()))
>          FAIL(AVERROR(ENOMEM));
> --
> 2.5.0
>

5+ was only minor version number,
and I changed commit message to only what I know and not what I suspect.


More information about the ffmpeg-devel mailing list