[FFmpeg-devel] [GSoC] BDA (DTV) Capture / tuning -- work-in-progress
michael at niedermayer.cc
Sat Aug 22 13:08:36 CEST 2015
On Sat, Aug 22, 2015 at 05:18:04AM +0200, Máté Sebők wrote:
> > fails to build with mingw due to missing header
> > In file included from ffmpeg/libavdevice/dshow.c:33:0:
> > ffmpeg/libavdevice/bdadefs.h:8:24: fatal error: combaseapi.h: No such
> > file or directory
> > compilation terminated.
> > make: *** [libavdevice/dshow.o] Error 1
> > maybe a header check is needed in configure
> Maybe fixed... unnecessary headers removed (also some cleanup in the
i can confirm, the new patch builds fine with mingw here
> > +
> > > + gfilename = malloc((strlen(ctx->dtv_graph_
> > file)+4)*sizeof(WCHAR));
> > is this intended to be malloc() instead of av_malloc() ?
> Yes, it was intended, only a filename buffer for char-to-widechar
normally code in FFmpeg uses av_malloc() unless there is need for
the buffer to be passed into external functions which require a
full review left to roger and anyone else who wants to review
Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB
Rewriting code that is poorly written but fully understood is good.
Rewriting code that one doesnt understand is a sign that one is less smart
then the original author, trying to rewrite it will not make it better.
-------------- next part --------------
A non-text attachment was scrubbed...
Size: 181 bytes
Desc: Digital signature
More information about the ffmpeg-devel