[FFmpeg-devel] MP4 muxer, HEVC issues

[Arthur Grant]

I found two HEVC specific issues in the MP4 muxer.

1) File libavformat\hevc.c, hvcc_parse_pps()
pps_slice_chroma_qp_offsets_present_flag is missing

-------------
    /*
     * weighted_pred_flag               u(1)
     * weighted_bipred_flag             u(1)
     * transquant_bypass_enabled_flag   u(1)
     */
    skip_bits(gb, 3);
-------------

Should be

-------------
    /*
     * pps_slice_chroma_qp_offsets_present_flag u(1)
     * weighted_pred_flag               u(1)
     * weighted_bipred_flag             u(1)
     * transquant_bypass_enabled_flag   u(1)
     */
    skip_bits(gb, 4);
-------------

2) File libavformat\hevc.c, hvcc_parse_sps()

-------------
for (i = 0; i < get_ue_golomb_long(gb); i++) { // num_long_term_ref_pics_sps
-------------

Is not correct. get_ue_golomb_long(gb) is evaluated multiple times.