[FFmpeg-devel] [PATCH] avfilter/vf_dejudder: use the name 's' for the pointer to the private context

Ganesh Ajjanagadde gajjanag at mit.edu
Thu Aug 20 20:06:18 CEST 2015

On Thu, Aug 20, 2015 at 1:53 PM, Clément Bœsch <u at pkh.me> wrote:
> On Thu, Aug 20, 2015 at 01:10:43PM -0400, Ganesh Ajjanagadde wrote:
> [...]
>> I know what s is doing, I just fail to see the connection between the name
>> "s" and "filter private context".
> s originally stands for struct iirc

If that is the case, then it is essentially the most uninformative
name one can use.
At least "p" tells us that it is private.
Note that if we did not use typedefs for the structs, it actually
conveys zero information.
I am now even more convinced that changing things to "s" across
filters is a bad idea.

> --
> Clément B.
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel at ffmpeg.org
> http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

More information about the ffmpeg-devel mailing list