[FFmpeg-devel] [PATCH 1/2] lavf/http: Parse and/or expose various client data.

Stephan Holljes klaxa1337 at googlemail.com
Thu Aug 20 17:23:49 CEST 2015


On Thu, Aug 20, 2015 at 5:15 PM, Nicolas George <george at nsup.org> wrote:
> Le tridi 3 fructidor, an CCXXIII, Stephan Holljes a écrit :
>> Added to all while(!av_isspace(p)) loops in the server code.
>
> You may want to send this part in a stand-alone patch, since it is actually
> a bug in the current code.
>
>> This is more or less temporal, since the user-agent field is/will be
>> used by ffserver.
>> Once headers are handled by an AVDictionary this code will probably be removed.
>
> I suspect you meant "temporary". In that case, I suggest to leave that bit
> out, until either it is replaced by AVDictionary or the FFserver patch
> itself is ready, whatever comes first: even with the API marked
> experimental, it is not nice to start offering an option and then remove it
> if it can be avoided.

Should the same be done for the Host-parameter sent by the client too?

>
> Regards,
>
> --
>   Nicolas George
>
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel at ffmpeg.org
> http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>


More information about the ffmpeg-devel mailing list