[FFmpeg-devel] [PATCH 03/13] avfilter: add missing FF_API_AVFILTERBUFFER guards
andreas.cadhalpun at googlemail.com
Sun Aug 16 18:15:29 CEST 2015
On 16.08.2015 12:28, Michael Niedermayer wrote:
> On Sun, Aug 16, 2015 at 10:48:57AM +0200, Nicolas George wrote:
>> Le nonidi 29 thermidor, an CCXXIII, Michael Niedermayer a écrit :
>>> Why is av_buffersink_poll_frame deprecated and removed ?
>> Its original semantic of recursing through the graph to count the available
>> frames was unsustainable, some filters did return only a very rough
>> estimate and some needed very complex code to get an accurate estimate.
> i might misremember as i didnt work much on that code recently but
> i think it was never intended to give an exact number, just a
> value that was guranteed to be available, which would not imply
> that there arent more available
> an exact number would be unsustainable, yes
>> With the current requirement that no frame accumulate within the filter
>> graph, it can be replaced by just querying the sink, possibly with the PEEK
>> and/or NO_REQUEST flags.
> PEEK/NO_REQUEST would tell if the fifo is empty or not
> av_buffersink_poll_frame() basically provided the user application
> with the number of frames in the fifo (plus what it could figure
> out from previous filters) but my concern is about loosing the
> detailed information about the fifo
av_buffersink_poll_frame has been deprecated since 2013 (commit 7e6c67dd7e6c67dd).
By now it isn't really used anymore, so I doubt many would miss it.
More information about the ffmpeg-devel