[FFmpeg-devel] [PATCH 12/13] buffersink: use sizeof(void *) because AVFilterBufferRef is deprecated

Andreas Cadhalpun andreas.cadhalpun at googlemail.com
Sun Aug 16 18:12:19 CEST 2015

On 16.08.2015 04:53, Michael Niedermayer wrote:
> On Sat, Aug 08, 2015 at 01:33:14PM +0200, Andreas Cadhalpun wrote:
>> Signed-off-by: Andreas Cadhalpun <Andreas.Cadhalpun at googlemail.com>
>> ---
>>  libavfilter/buffersink.c | 12 ++++++------
>>  1 file changed, 6 insertions(+), 6 deletions(-)
> should be ok, if sizeof(type)is preferred over sizeof(somevar)

Well, it was sizeof(type) before...
But looking at bit more at that code I think that it would be better
to #define this value to a reasonable name, similar to FIFO_INIT_SIZE.

Attached patch does this. Do you agree that this is better?

Best regards,

-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-buffersink-introduce-FIFO_INIT_ELEMENT_SIZE-to-compl.patch
Type: text/x-diff
Size: 3506 bytes
Desc: not available
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20150816/e3077591/attachment.patch>

More information about the ffmpeg-devel mailing list