[FFmpeg-devel] [PATCH 2/3] RFC: Should be squashed in the previous patch if OK

Alexander Strasser eclipse7 at gmx.net
Sat Aug 15 00:44:57 CEST 2015


On 2015-08-14 17:35 -0400, Ganesh Ajjanagadde wrote:
> On Fri, Aug 14, 2015 at 4:46 PM, Alexander Strasser <eclipse7 at gmx.net> wrote:
> > Signed-off-by: Alexander Strasser <eclipse7 at gmx.net>
> > ---
> >  libavutil/parseutils.h | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/libavutil/parseutils.h b/libavutil/parseutils.h
> > index b04aa89..cff5123 100644
> > --- a/libavutil/parseutils.h
> > +++ b/libavutil/parseutils.h
> > @@ -112,7 +112,7 @@ int av_parse_color(uint8_t *rgba_color, const char *color_string, int slen,
> >  const char *av_get_known_color_name(int color_idx, const uint8_t **rgb);
> >
> >  /**
> > - * Parse timestr and return in *timeval a corresponding number of
> > + * Parse timestr and return in *timeval the corresponding number of
> >   * microseconds.
> >   *
> >   * @param timeval puts here the number of microseconds corresponding
> > --
> >
> So how exactly is this different from patch 1/3?
> Are you sure you emailed the right patch?

Here I replaced "a" with "the". Saying it returns *a* corresponding
number of microseconds kind of suggests there is more then one value
it could choose from.

Well maybe you could say the original is kind of true for dates
because of timezones etc...  Anyway it is more like a cosmetic
change if it doesn't resonate with others, I will just drop
this patch.


  Alexander
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 181 bytes
Desc: not available
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20150815/e6a93159/attachment.sig>


More information about the ffmpeg-devel mailing list