[FFmpeg-devel] [PATCH] swscale: Make sws_alloc_set_opts() public

wm4 nfxjfg at googlemail.com
Sat Aug 8 19:45:23 CEST 2015


On Sat, 8 Aug 2015 19:05:39 +0200
Michael Niedermayer <michael at niedermayer.cc> wrote:

> > Where are the
> > input and output colorspaces and ranges set?
> 
> they would be set with sws_setColorspaceDetails()

But they're pretty important, so why aren't they part of the parameter
list too? In the end, the parameter list would grow too long. Or it
would be kind of inconsistent. (Maybe convenience functions like e.g.
"sws_set_input_size()" would be helpful without being terribly
unorthogonal.)

> > There's my very old patch, which made libswscale transparently set the
> > parameters of an input AVFrame. This would actually be the simplest API.
> 
> can you update the patch so the comments raised by stefano are taken
> care of ?

My main worry about this is that if new fields are added to AVFrame,
the new libswscale API would have to pick them up and adjust the scaler
settings accordingly. So if the user was setting this option manually,
a change to libswscale setting this option automatically from AVFrame
would break the user code.

Distinguish between set and unset options might help here.


More information about the ffmpeg-devel mailing list