[FFmpeg-devel] [PATCH 3/3] avcodec/utils: Favor using the internal->byte_buffer in ff_alloc_packet2()

[Paul B Mahol]

Dana 4. 8. 2015. 10:48 osoba "Michael Niedermayer" <michaelni at gmx.at>
napisala je:
>
> From: Michael Niedermayer <michael at niedermayer.cc>
>
> This would allow dropping min_size
>
> This causes matrixbench encoding to rawvideo to drop in speed from
> 4.204 to 4.210sec
> The effect has been previously seen to be much larger at higher
> resolutions

Why then posting this patch at all?
It makes things slow.
>
> Signed-off-by: Michael Niedermayer <michael at niedermayer.cc>
> ---
>  libavcodec/utils.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/libavcodec/utils.c b/libavcodec/utils.c
> index 8f3bffd..c98a840 100644
> --- a/libavcodec/utils.c
> +++ b/libavcodec/utils.c
> @@ -1789,7 +1789,7 @@ int ff_alloc_packet2(AVCodecContext *avctx,
AVPacket *avpkt, int64_t size, int64
>          return AVERROR(EINVAL);
>      }
>
> -    if (avctx && avpkt->data && avpkt->size < size) {
> +    if (avctx) {
>          av_assert0(!avpkt->data || avpkt->data !=
avctx->internal->byte_buffer);
>          if (!avpkt->data || avpkt->size < size) {
>              av_fast_padded_malloc(&avctx->internal->byte_buffer,
&avctx->internal->byte_buffer_size, size);
> --
> 1.7.9.5
>
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel at ffmpeg.org
> http://ffmpeg.org/mailman/listinfo/ffmpeg-devel