[FFmpeg-devel] [PATCH 1/4] x86inc: Support arbitrary stack alignments

Ronald S. Bultje rsbultje at gmail.com
Mon Aug 3 02:18:57 CEST 2015


Hi,

On Sun, Aug 2, 2015 at 4:40 PM, Henrik Gramner <henrik at gramner.com> wrote:

> Change ALLOC_STACK to always align the stack before allocating stack space
> for
> consistency. Previously alignment would occur either before or after
> allocating
> stack space depending on whether manual alignment was required or not.
> ---
>  libavcodec/x86/h264_deblock.asm |  4 +--
>  libavutil/x86/x86inc.asm        | 62
> ++++++++++++++++++++++++++---------------
>  2 files changed, 42 insertions(+), 24 deletions(-)


So, I think the code changes themselves look mostly healthy. Is there a
behavioural difference before/after this patch? (Like: were there bugs in
the original code, or does this change behaviour of previous code in a
significant way?)

Thanks,
Ronald


More information about the ffmpeg-devel mailing list